Skip to content

Fix prev/next keyboard navigation #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix prev/next keyboard navigation #3787

merged 1 commit into from
Aug 15, 2024

Conversation

squidfunk
Copy link
Contributor

Supersedes #3729 to fix #3728. I accidentally closed the PR by deleting my fork when cleaning up my repositories.

@tomchristie
Copy link
Member

@squidfunk Do you want merge permissions to help squish some of these existing PRs?

@squidfunk
Copy link
Contributor Author

Thanks, but I'll leave the merge to you, as I don't know when you want to release the fixes 🤟 Let me know if you need anything else. Feel free to tag me in problems related to the jQuery removal in 1.6 – I'll provide fixes asap.

@squidfunk
Copy link
Contributor Author

@tomchristie friendly ping. Do you have an ETA for when the latest changes + approved PRs will be released?

I think the community desperately awaits the 1.6.1 release that includes this and other bugfixes. The current default MkDocs theme has several bugs due to the jQuery removal that I fixed immediately as they were reported, but my contributions are still unreleased and almost all users that use the default mkdocs theme are impacted. I know you're working on MkDocs 2.0, but it would be great to see the community's work not go to waste until 2.0 is ready for prime time.

@tomchristie tomchristie merged commit 8058b78 into mkdocs:master Aug 15, 2024
17 checks passed
@tomchristie
Copy link
Member

No worries yep. I'll have availability to ensure a release next week. @mkdocs/core could y'all bump any tickets that need inclusion?

@squidfunk
Copy link
Contributor Author

@pawamoy
Copy link
Collaborator

pawamoy commented Aug 15, 2024

@pawamoy
Copy link
Collaborator

pawamoy commented Aug 17, 2024

Another quick docs PR: #3808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default theme: N and P keys no longer work
3 participants