Skip to content

Add Screen Wake Lock position (worth prototyping) #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Conversation

marcoscaceres
Copy link
Contributor

Closes #210

@marcoscaceres marcoscaceres requested a review from dbaron March 26, 2020 03:39
Copy link
Contributor

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but the bugzilla url should definitely be fixed, and see a possible suggestion about the comment.

activities.json Outdated
"ciuName": null,
"description": "This document specifies an API that allows web applications to request a screen wake lock. Under the right conditions, and if allowed, the screen wake lock prevents the system from turning off a device's screen.",
"id": "screen-wake-lock",
"mozBugUrl": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activities.json Outdated
"id": "screen-wake-lock",
"mozBugUrl": null,
"mozPosition": "worth prototyping",
"mozPositionDetail": "As the scope of the specification has been reduced to screen wake locks, it's worth prototyping this API in a manner that restricts it to foreground first-party content. Additionally, the API appears flexible enough that a permission grant can be performed asynchronously, allowing us to evaluate the most appropriate permission model should we choose to ship this API in the future. As the API allows the capability to be revoked at any time, we can also prototype eagerly granting, notifying the user what's going on, and allowing users to disable the capability entirely - either per origin, or globally through a browser setting.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth mentioning somewhere that the potential downside is the risk of abuse by sites that don't have a strong need for it, degrading battery life for the sake of engagement? Or something like that?

@dbaron dbaron merged commit 30f1adb into master Mar 26, 2020
@marcoscaceres marcoscaceres deleted the screenwakelock branch March 26, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen Wake Lock API
2 participants