Skip to content

git: Update alias and function deprecations #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rivenirvana
Copy link

@rivenirvana rivenirvana commented Jun 1, 2025

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Remove deprecated git pull --rebase aliases
  • Start deprecating ggpull/ggpur/ggpush for their alternative functions
  • Start deprecating current_branch function in favor of what's in core
  • Update README to reflect above changes and undocument some long-removed aliases

Other comments:

I'm gonna be honest, I only wanted to just be able to use gup without unalias-ing it first in my zshrc. But the code for deprecation warnings seemed like a waste to just remove, and after taking a look it felt like some parts needed updates too, so why not make use of it so we can proceed with a system where we can actually transition functionalities from soft deprecation to removal? Some of these have been sitting here for a while now, after all (>2 years). Appreciate any feedback/conversation regarding this.

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request labels Jun 1, 2025
@ohmyzsh ohmyzsh bot added this to Main project Jun 1, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Main project Jun 1, 2025
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from dd24941 to b0f4115 Compare June 10, 2025 02:17
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 2 times, most recently from de480ae to 31cfd38 Compare June 21, 2025 01:57
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 31cfd38 to 62df87a Compare June 26, 2025 13:40
There are some aliases, whose functionality has long been reassigned to
different aliases, but have not been reused for new commands, yet are
still documented in the README. Remove them.
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 62df87a to cfe6cc6 Compare July 11, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant