Skip to content

[#13106] Update keychain plugin to support 2.9.0+ without warnings #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zack6849
Copy link

Keychain versions 2.9.0 and higher removed support for the --agents option and squawk in console constantly if the option isn't removed, now we check to make sure that the keychain version is less than 2.9.0 before passing the argument

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Changed the plugin to only pass --agents on versions lower than 2.9.0

Other comments:

I tested this with keychain v 2.9.5 on arch and it seems to work, however i'm not sure if the version output is the same on other operating systems, we could also just change this to not pass the option at all, or only pass the agents option if some flag is set or something, open to suggestions / criticisim

Keychain versions 2.9.0 and higher removed support for the --agents option and squawk in console constantly if the option isn't removed, now we check to make sure that the keychain version is less than 2.9.0 before passing the argument
@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jun 27, 2025
@ohmyzsh ohmyzsh bot added this to Main project Jun 27, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Main project Jun 27, 2025
@zack6849
Copy link
Author

zack6849 commented Jul 3, 2025

@marcofranssen any chance you could review this when you get a chance?

Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants