Skip to content

Use \d #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use \d #6423

wants to merge 2 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 13, 2025

Upgrading the GitHub action to run on Ubuntu 24.04 with Python 3.12 to synchronize the documentation from various repositories has led to some failures
See https://github.com/ome/omero-documentation/actions/runs/13825561909

This is the first part of the puzzle.
Changes are required in other repositories e.g. omeroweb-install and ansible

@joshmoore
Copy link
Member

Interesting. What changed to make this start failing, @jburel ?

@jburel
Copy link
Member Author

jburel commented Mar 13, 2025

documentation/OMERO.server/components/antlib/scripts/parse_version:76: SyntaxWarning: invalid escape sequence '\d'   "(?P<STRIP>([-]DEV)?-\d+-[a-f0-9]+?(-dirty)?)" /home/runner/work/omero-documentation/OMERO.server/components/antlib/scripts/parse_version:118: SyntaxWarning: invalid escape sequence '\d'   m = re.match("^([^\d]*\d+[.]\d+[.])(\d+)-SNAPSHOT$", omero_version) 5.6.14-ice36-SNAPSHOT). Use forcedeliver or update.

This is due to the fact that we are running with 3.12

@joshmoore
Copy link
Member

This is due to the fact that we are running with 3.12

Gotcha.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the language changes announced in https://docs.python.org/dev/whatsnew/3.12.html#other-language-changes

I would suggest we follow the official recommendation and use raw strings for regular expressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants