Added grub.py that will help to automate grub test cases. #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added measure_boot_time function that will measure boot timing from reboot to grub menu and from grub menu to kernel loading. Signed-off-by: Krishan Gopal Saraswat <krishang@linux.ibm.com>
| ''' | ||
| log.info("Starting boot time measurement test") | ||
| boot_times = self.measure_boot_time() | ||
| # Print results |
There was a problem hiding this comment.
Can you please remove this comment, even wherever possible, if required, push as a logger, or method doc string
| except pexpect.TIMEOUT: | ||
| log.error("Timeout waiting for boot sequence") | ||
| log.error("Last console output: %s" % self.console.pty.before) | ||
| raise OpTestError("Boot sequence timeout") |
There was a problem hiding this comment.
Instead of Error out, can we able to recover the system using test ? or it kept manual
| raise OpTestError("Boot sequence timeout") | ||
| except Exception as e: | ||
| log.error("Unexpected error during boot sequence: %s" % str(e)) | ||
| raise |
There was a problem hiding this comment.
raising any error?
|
|
||
| class Grub(unittest.TestCase): | ||
| ''' | ||
| Test case to measure boot timing |
There was a problem hiding this comment.
can we reword like
Test case to measure system boot timing
|
|
||
| def measure_boot_time(self): | ||
| ''' | ||
| Measure boot timing from reboot to grub menu and from grub menu to kernel loading |
sacsant
reviewed
Jul 3, 2025
| #!/usr/bin/env python3 | ||
| # OpenPOWER Automated Test Project | ||
| # | ||
| # Contributors Listed Below - COPYRIGHT 2017 |
| self.cv_HOST = self.conf.host() | ||
| self.console = self.cv_SYSTEM.console | ||
|
|
||
| def measure_boot_time(self): |
There was a problem hiding this comment.
Can we pick another name to convey the exact use case? boot_time is very generic.
|
@Krishan-Saraswat Please have a look at the review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added measure_boot_time function that will measure boot timing from reboot to grub menu and from grub menu to kernel loading.
output snippet of running this test:-
2025-05-20 15:47:11,332:op-test.testcases.grub:runTest:INFO:Boot Time Results:
2025-05-20 15:47:11,332:op-test.testcases.grub:runTest:INFO:-----------------
2025-05-20 15:47:11,333:op-test.testcases.grub:runTest:INFO:Reboot to GRUB menu: 14.84 seconds
2025-05-20 15:47:11,333:op-test.testcases.grub:runTest:INFO:GRUB menu to kernel loading: 8.92 seconds
2025-05-20 15:47:11,333:op-test.testcases.grub:runTest:INFO:Total boot time: 23.76 seconds