Added test to build, compile and run secvarctl test. #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to build, compile, run secvarctl and generate keys/auth files. Signed-off-by: Krishan Gopal Saraswat <krishang@linux.ibm.com>
PraveenPenguin
requested changes
Jul 11, 2025
| @@ -0,0 +1,92 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
Please have a header added .. you can inspire from other test
| if self.distro_name == 'rhel': | ||
| self.cv_HOST.host_run_command(f"{self.installer} {pkg} -y") | ||
| elif self.distro_name == 'sles': | ||
| self.cv_HOST.host_run_command(f"{self.installer} -y {pkg}") |
There was a problem hiding this comment.
please move this logic in utils . and we can drive that from test like just passing package name
|
|
||
| self.build_path = os.path.join(self.home, "secvarctl") | ||
| self.connection.run_command("cd {} && mkdir -p build && cd build".format(self.build_path)) | ||
| self.connection.run_command("cmake ../") |
There was a problem hiding this comment.
If make or other build commands fail, we should not jump in the next step .. is except is able to catch these scenario
abdhaleegit
requested changes
Jul 14, 2025
There was a problem hiding this comment.
@Krishan-Saraswat @PraveenPenguin just curious why this test in op-test and not in avocado misc ?
|
|
||
|
|
||
| class SecvarctlTest(unittest.TestCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
some doc string to explain what test does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to build, compile, run secvarctl and generate keys/auth files.
Ran 1 test in 164.866s
OK
Generating XML reports...
Generated XML report: /home/op-test/test-reports/test-run-20250710081144/TEST-testcases.OpTestSecvarctl.SecvarctlTest-20250710081144.xml