Skip to content

feat(EntityTitle): Add fill to EntityTitle #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2024
Merged

feat(EntityTitle): Add fill to EntityTitle #6973

merged 3 commits into from
Sep 13, 2024

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Sep 12, 2024 •
edited
Loading

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds a new boolean fill property to EntityTitle that controls whether or not the title inside of the EntityTitle component will expand and cause it to horizontally fill its container. This is useful in situations where the icon/title/subtitle and label element should be separated from each other, such as when multiple entity titles are displayed next to each other in a vertical list.

Screenshot 2024-09-12 at 15 35 14

Screenshot 2024-09-12 at 15 37 10@2x

Screenshot 2024-09-12 at 15 51 44@2x

@changelog-app
Copy link

changelog-app bot commented Sep 12, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat(EntityTitle): Add fill to EntityTitle

Generate changelog in packages/docs-app/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat(EntityTitle): Add fill to EntityTitle

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add test case

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Add example to demo-app

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit d5f710f into develop Sep 13, 2024
12 of 16 checks passed
@ggdouglas ggdouglas deleted the gdouglas/entity-title-fill branch September 13, 2024 13:11
@ggdouglas ggdouglas mentioned this pull request Dec 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheiny jscheiny jscheiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggdouglas @svc-palantir-github @jscheiny