Skip to content

feat: new icon - object view #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat: new icon - object view #7113

merged 3 commits into from
Dec 10, 2024

Conversation

josephpinto
Copy link
Contributor

@josephpinto josephpinto commented Dec 6, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

adds the object view icon

Reviewers should focus on:

Screenshot

image (18)

@changelog-app
Copy link

changelog-app bot commented Dec 6, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat: new icon - object view

Check the box to generate changelog(s)

  • Generate changelog entry

@josephpinto josephpinto force-pushed the joepinto/object-view-icon branch from 086334b to a399ba4 Compare December 6, 2024 19:50
@svc-palantir-github
Copy link

feat: new icon - object view

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ryannono
Copy link
Contributor

ryannono commented Dec 6, 2024

  • Design checked

@josephpinto josephpinto marked this pull request as ready for review December 6, 2024 23:34
@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ashleighp13 ashleighp13 requested a review from jscheiny December 9, 2024 23:59
@svc-palantir-github
Copy link

remove unnecessary attributes

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@josephpinto josephpinto merged commit ac4ef67 into develop Dec 10, 2024
13 checks passed
@josephpinto josephpinto deleted the joepinto/object-view-icon branch December 10, 2024 20:14
sc-mitton pushed a commit to sc-mitton/blueprint that referenced this pull request Jan 7, 2025
Co-authored-by: Joe Pinto <joepinto@palantir.com>
Co-authored-by: svc-changelog <svc-changelog@palantir.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants