Skip to content

feat: new icon - array of objects #7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 21, 2025
Merged

feat: new icon - array of objects #7190

merged 4 commits into from
Jan 21, 2025

Conversation

faye-tan
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

@changelog-app
Copy link

changelog-app bot commented Jan 21, 2025 •
edited by faye-tan
Loading

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat: new icon - array of objects

Check the box to generate changelog(s)

  • Generate changelog entry

ggdouglas
ggdouglas reviewed Jan 21, 2025
View reviewed changes
packages/icons/icons.json Outdated
"iconName": "array-object",
"tags": "data, type, list, object",
"group": "miscellaneous",
"codepoint": 61729
Copy link
Contributor

@ggdouglas ggdouglas Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this entry to the bottom of the icon manifest?

Suggested change
"codepoint": 61729
"codepoint": 62356

This will also fix the compile error here:

Invalid metadata entry in icons.json: icon "array-object" cannot have codepoint 61729, it is already in use.

resources/icons/16px/array-object.svg Outdated
@@ -0,0 +1,6 @@
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the width, height, and fill attributes from the elements in this SVG. They are not needed.

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<path d="M4 0C4.55228 0 5 0.447715 5 1C5 1.51284 4.61396 1.93551 4.11662 1.99327L4 2H2V14H4C4.51284 14 4.93551 14.386 4.99327 14.8834L5 15C5 15.5128 4.61396 15.9355 4.11662 15.9933L4 16H1C0.487164 16 0.0644928 15.614 0.00672773 15.1166L0 15V1C0 0.487164 0.38604 0.0644928 0.883379 0.00672773L1 0H4Z"/>
<path d="M15 0C15.5128 0 15.9355 0.38604 15.9933 0.883379L16 1V15C16 15.5128 15.614 15.9355 15.1166 15.9933L15 16H12C11.4477 16 11 15.5523 11 15C11 14.4872 11.386 14.0645 11.8834 14.0067L12 14H14V2H12C11.4872 2 11.0645 1.61396 11.0067 1.11662L11 1C11 0.487164 11.386 0.0644928 11.8834 0.00672773L12 0H15Z"/>
<path d="M6.5 3C5.85376 3 5.34853 3.20474 5.08412 3.72516C4.96694 3.95579 4.92395 4.20217 4.90755 4.41676C4.89125 4.63006 4.89905 4.85058 4.90677 5.03912C4.92399 5.46023 4.93451 6.84749 4.86735 7.06306C4.83958 7.15221 4.80029 7.21986 4.74067 7.27719C4.67831 7.33715 4.57067 7.40772 4.37873 7.46103C4.15615 7.52286 4 7.74507 4 8C4 8.25493 4.15615 8.47714 4.37873 8.53897C4.57067 8.59229 4.67831 8.66285 4.74067 8.72281C4.80029 8.78014 4.83958 8.84779 4.86735 8.93694C4.93451 9.15251 4.92399 10.5398 4.90677 10.9609C4.89905 11.1494 4.89125 11.3699 4.90755 11.5832C4.92395 11.7978 4.96694 12.0442 5.08412 12.2748C5.34853 12.7953 5.85376 13 6.5 13C6.77614 13 7 12.7513 7 12.4444C7 12.1376 6.77614 11.8889 6.5 11.8889C6.03343 11.8889 5.96716 11.7536 5.95573 11.7302L5.95494 11.7286C5.9354 11.6902 5.91394 11.6197 5.90397 11.4892C5.8939 11.3575 5.89782 11.2047 5.90573 11.0113C5.90679 10.9856 5.90797 10.9588 5.90919 10.9311C5.9242 10.5904 5.94531 9.00031 5.81234 8.57348C5.74925 8.37099 5.65127 8.17435 5.50481 8C5.65127 7.82566 5.74925 7.62901 5.81234 7.42652C5.94531 6.99969 5.9242 5.40961 5.90919 5.06887C5.90797 5.0412 5.90679 5.01441 5.90573 4.98866C5.89782 4.79526 5.8939 4.64251 5.90397 4.51076C5.91394 4.3803 5.9354 4.30983 5.95494 4.27137L5.95573 4.26978C5.96716 4.24644 6.03343 4.11111 6.5 4.11111C6.77614 4.11111 7 3.86238 7 3.55556C7 3.24873 6.77614 3 6.5 3Z"/>
<path d="M9.5 3C10.1462 3 10.6515 3.20474 10.9159 3.72516C11.0331 3.95579 11.076 4.20217 11.0924 4.41676C11.1087 4.63006 11.1009 4.85058 11.0932 5.03912C11.076 5.46023 11.0655 6.84749 11.1326 7.06306C11.1604 7.15221 11.1997 7.21986 11.2593 7.27719C11.3217 7.33715 11.4293 7.40772 11.6213 7.46103C11.8439 7.52286 12 7.74507 12 8C12 8.25493 11.8439 8.47714 11.6213 8.53897C11.4293 8.59229 11.3217 8.66285 11.2593 8.72281C11.1997 8.78014 11.1604 8.84779 11.1326 8.93694C11.0655 9.15251 11.076 10.5398 11.0932 10.9609C11.1009 11.1494 11.1087 11.3699 11.0924 11.5832C11.076 11.7978 11.0331 12.0442 10.9159 12.2748C10.6515 12.7953 10.1462 13 9.5 13C9.22386 13 9 12.7513 9 12.4444C9 12.1376 9.22386 11.8889 9.5 11.8889C9.96657 11.8889 10.0328 11.7536 10.0443 11.7302L10.0451 11.7286C10.0646 11.6902 10.0861 11.6197 10.096 11.4892C10.1061 11.3575 10.1022 11.2047 10.0943 11.0113C10.0932 10.9856 10.092 10.9588 10.0908 10.9311C10.0758 10.5904 10.0547 9.00031 10.1877 8.57348C10.2507 8.37099 10.3487 8.17435 10.4952 8C10.3487 7.82566 10.2507 7.62901 10.1877 7.42652C10.0547 6.99969 10.0758 5.40961 10.0908 5.06887C10.092 5.0412 10.0932 5.01441 10.0943 4.98866C10.1022 4.79526 10.1061 4.64251 10.096 4.51076C10.0861 4.3803 10.0646 4.30983 10.0451 4.27137L10.0443 4.26978C10.0328 4.24644 9.96657 4.11111 9.5 4.11111C9.22386 4.11111 9 3.86238 9 3.55556C9 3.24873 9.22386 3 9.5 3Z"/>
</svg>

resources/icons/20px/array-object.svg Outdated
@@ -0,0 +1,5 @@
<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here re: removing unneeded attributes:

<svg viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg">
<path d="M19 0C19.5128 0 19.9355 0.38604 19.9933 0.883379L20 1V19C20 19.5128 19.614 19.9355 19.1166 19.9933L19 20H15C14.4477 20 14 19.5523 14 19C14 18.4872 14.386 18.0645 14.8834 18.0067L15 18H18V2H15C14.4872 2 14.0645 1.61396 14.0067 1.11662L14 1C14 0.487164 14.386 0.0644928 14.8834 0.00672773L15 0H19Z"/>
<path d="M5 0C5.55228 0 6 0.447715 6 1C6 1.51284 5.61396 1.93551 5.11662 1.99327L5 2H2V18H5C5.51284 18 5.93551 18.386 5.99327 18.8834L6 19C6 19.5128 5.61396 19.9355 5.11662 19.9933L5 20H1C0.487164 20 0.0644928 19.614 0.00672773 19.1166L0 19V1C0 0.487164 0.38604 0.0644928 0.883379 0.00672773L1 0H5Z"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M8.1026 4C7.68813 4 7.29065 4.16464 6.99758 4.45771C6.70451 4.75078 6.53987 5.14827 6.53987 5.56273V8.03631C6.53987 8.41673 6.34609 8.77035 6.0264 8.97574L5.30843 9.43563C5.21386 9.49622 5.13604 9.57963 5.08215 9.67817C5.02825 9.77672 5 9.88723 5 9.99955C5 10.1119 5.02825 10.2224 5.08215 10.3209C5.13604 10.4195 5.21386 10.5029 5.30843 10.5635L6.0264 11.0234C6.34609 11.2288 6.53987 11.5833 6.53987 11.9637V14.4373C6.53987 15.2999 7.23997 16 8.1026 16H8.44729C8.62492 16 8.79527 15.9294 8.92087 15.8038C9.04647 15.6782 9.11703 15.5079 9.11703 15.3303C9.11703 15.1526 9.04647 14.9823 8.92087 14.8567C8.79527 14.7311 8.62492 14.6605 8.44729 14.6605H8.1017C8.0425 14.6605 7.98571 14.637 7.94384 14.5951C7.90198 14.5533 7.87846 14.4965 7.87846 14.4373V11.9637C7.87856 11.5825 7.78994 11.2066 7.6196 10.8656C7.44926 10.5246 7.20189 10.2279 6.89706 9.99911C7.20165 9.77045 7.44887 9.47408 7.6192 9.13343C7.78953 8.79278 7.87828 8.41718 7.87846 8.03631V5.56273C7.87846 5.50352 7.90198 5.44674 7.94384 5.40487C7.98571 5.36301 8.0425 5.33949 8.1017 5.33949H8.4464C8.53435 5.33949 8.62144 5.32216 8.7027 5.2885C8.78395 5.25485 8.85779 5.20551 8.91998 5.14332C8.98217 5.08113 9.0315 5.0073 9.06516 4.92604C9.09882 4.84479 9.11614 4.75769 9.11614 4.66974C9.11614 4.58179 9.09882 4.4947 9.06516 4.41344C9.0315 4.33219 8.98217 4.25835 8.91998 4.19616C8.85779 4.13397 8.78395 4.08464 8.7027 4.05098C8.62144 4.01732 8.53435 4 8.4464 4H8.1026ZM11.7104 4C12.5739 4 13.2732 4.7001 13.2732 5.56273V8.03631C13.2732 8.41673 13.4678 8.77035 13.7875 8.97574L14.5055 9.43563C14.6001 9.49622 14.6779 9.57963 14.7318 9.67817C14.7857 9.77672 14.8139 9.88723 14.8139 9.99955C14.8139 10.1119 14.7857 10.2224 14.7318 10.3209C14.6779 10.4195 14.6001 10.5029 14.5055 10.5635L13.7875 11.0234C13.6299 11.1245 13.5003 11.2636 13.4106 11.4279C13.3209 11.5922 13.2739 11.7765 13.2741 11.9637V14.4373C13.2741 14.8517 13.1094 15.2492 12.8163 15.5423C12.5233 15.8354 12.1258 16 11.7113 16H11.3666C11.189 16 11.0186 15.9294 10.893 15.8038C10.7674 15.6782 10.6969 15.5079 10.6969 15.3303C10.6969 15.1526 10.7674 14.9823 10.893 14.8567C11.0186 14.7311 11.189 14.6605 11.3666 14.6605H11.7113C11.7705 14.6605 11.8273 14.637 11.8692 14.5951C11.911 14.5533 11.9346 14.4965 11.9346 14.4373V11.9637C11.9346 11.1868 12.3007 10.4617 12.9151 9.99911C12.6106 9.77036 12.3636 9.47395 12.1934 9.1333C12.0233 8.79265 11.9346 8.4171 11.9346 8.03631V5.56273C11.9346 5.50352 11.911 5.44674 11.8692 5.40487C11.8273 5.36301 11.7705 5.33949 11.7113 5.33949H11.3666C11.189 5.33949 11.0186 5.26892 10.893 5.14332C10.7674 5.01772 10.6969 4.84737 10.6969 4.66974C10.6969 4.49212 10.7674 4.32176 10.893 4.19616C11.0186 4.07056 11.189 4 11.3666 4H11.7104Z"/>
</svg>

@faye-tan faye-tan requested a review from ggdouglas January 21, 2025 20:07
@svc-palantir-github
Copy link

Merge branch 'faye-tan/add-new-struct-array-icon' of https://github.com/palantir/blueprint into faye-tan/add-new-struct-array-icon

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@faye-tan faye-tan merged commit fd7113b into develop Jan 21, 2025
13 checks passed
@faye-tan faye-tan deleted the faye-tan/add-new-struct-array-icon branch January 21, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdouglas ggdouglas ggdouglas approved these changes

Assignees
No one assigned
Labels
Package: icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faye-tan @svc-palantir-github @ggdouglas @svc-changelog