Skip to content

Feat(Icon) - Phone search #7225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Feat(Icon) - Phone search #7225

merged 2 commits into from
Feb 4, 2025

Conversation

ryannono
Copy link
Contributor

@ryannono ryannono commented Feb 3, 2025

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

New phone search icon

Reviewers should focus on:

  • Svg format
  • Icon JSON
  • Icon style

Screenshot

image

@changelog-app
Copy link

changelog-app bot commented Feb 3, 2025

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Feat(Icon) - Phone search

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

phone search

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas
ggdouglas previously approved these changes Feb 4, 2025
View reviewed changes
@policy-bot policy-bot bot dismissed ggdouglas’s stale review February 4, 2025 16:44

Invalidated by push of 9b8b5ed

@ryannono ryannono enabled auto-merge (squash) February 4, 2025 16:45
@svc-palantir-github
Copy link

Merge branch 'develop' into origin/rn/phone-search-icon

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ryannono ryannono merged commit 206b625 into develop Feb 4, 2025
12 of 14 checks passed
@ryannono ryannono deleted the origin/rn/phone-search-icon branch February 4, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdouglas ggdouglas ggdouglas approved these changes

Assignees
No one assigned
Labels
Package: icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryannono @svc-palantir-github @ggdouglas