Skip to content

Add icon support to Segment Control options #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

mattskrobola
Copy link
Contributor

@mattskrobola mattskrobola commented Apr 13, 2025

Fixes part of #6761 (comment)

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds icon to the segment control option interface to support passing an icon for each segment control option.

Updated docs to reflect this new option.

Screenshot

Screenshot 2025-04-13 at 4 20 15 PM

@mattskrobola mattskrobola changed the title Add icon option to segment control "options" Add icon support to Segment Control options Apr 14, 2025
Copy link
Contributor

@ggdouglas ggdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supportive of adding this in the short term to meet an immediate need!

Longer term, I question whether we should continue with the options pattern for these types of components vs. leveraging some other form of component composition.

@ggdouglas ggdouglas merged commit 8523564 into palantir:develop Apr 16, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants