[Camera] Add WebRTC Provider Server In python controller for Camera Initiated session flow. #39952
+418
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds WebRTC Provider Server endpoint definitions in dynamic_server/DynamicDispatcher.cpp - Implements provider delegates required for MVP Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the camera-initiated WebRTC session flow by implementing a WebRTC Provider Server in the Python controller. The changes are well-structured and include adding a new WebRTCTransportProviderManager, updating the dynamic dispatcher and access control for the new endpoint, and correcting the nodeId type to uint64_t for consistency. The Python bindings and WebRTCManager are also updated accordingly.
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
|
PR #39952: Size comparison from 00aa48e to e7c7b88 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
|
PR #39952: Size comparison from 00aa48e to 3a1b593 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marktrayer
approved these changes
Jul 11, 2025
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| constexpr chip::EndpointId kOtaProviderDynamicEndpointId = 0; | |||
| constexpr chip::EndpointId kWebRTCRequesterDynamicEndpointId = 1; | |||
| constexpr chip::EndpointId kWebRTCProviderDynamicEndpointId = 1; | |||
There was a problem hiding this comment.
Actually, this really confuses me: why are all users of DynamicDispatcher suddenly doing WebRTC? I know some of it was pre-existing, but that part looks wrong too.
There was a problem hiding this comment.
Thank you for your review. As you already know that for the Camera Controllers must have WebRTC-Transport-Requestor Server and in case of camera-initiated flow controller also needs to have WebRTC-Transport-Provider Server. This is currently being achieved by enabling dynamic server for these controllers.
There was a problem hiding this comment.
My point is that these are not the only consumers of DynamicDispatcher, and the way this is being hacked into the DynamicDispatcher is broken for all the other consumers.
bzbarsky-apple
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Just to be clear: the changes to DynamicDispatcher here are wrong, and will break non-camera users of DynamicDispatcher. DynamicDispatcher in its current state is not a generic dispatcher; it's hardcoded to do OTA, and OTA only, and the changes here don't really address that sufficiently.
The previous changes in #38153 that this is modeled off of were also wrong in the same way, but the right solution is to fix the already-broken things, not add more broken bits.
github-project-automation
bot
moved this from Todo
to In Progress
in [Device Type] Cameras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRTC Provider Server and WebRTC Requestor Client is needed in controller for Camera Initiated Flow. https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/webrtc.adoc#33-camera-initiated-flow
This PR
Testing