Removing unneeded get_test_info call #39967
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
src/python_testing/matter_testing_infrastructure/chip/testing/runner.py
Outdated
Show resolved
Hide resolved
…runner.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #39967: Size comparison from 6d5aa8c to 51fdb21 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
antonio-amjr
approved these changes
Jul 11, 2025
andy31415
reviewed
Jul 11, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/runner.py
Outdated
Show resolved
Hide resolved
|
Hi @andy31415 and @jtrejoespinoza-grid Looking closer, I noticed the I tested removing it, and the code still behaves as expected. Do you see any issues with just removing this call? |
Not sufficiently familiar with this, but if you checked and our tests pass, we can remove |
I'll wait @jtrejoespinoza-grid 's feedback before proceeding with the change. |
|
Hi @rquidute regarding your comments I made some test by removing the line with the code : I re-built the python files again and the run some test with commissioning on-network with the Linux App and then commissioning ble-wifi with a M5 Stack flashed with Let me provide the information that I was able to gather. 
Then build python env:
Then load the env:
Run one test locally using commissioning on-network using the Linux app:
Logs: Run one test using a device with commissioning ble-wifi:
Logs : |
|
Thanks @jtrejoespinoza-grid |
|
PR #39967: Size comparison from 6d5aa8c to 336c36a Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rquidute
changed the title
CommissionDeviceTest's get_test_info calls
andy31415
reviewed
Jul 14, 2025
raju-apple
approved these changes
Jul 14, 2025
|
I think it's fine to remove this for now to unblock the TH. @jtrejoespinoza-grid - I think I didn't realize the commissioning device test was refactored to pull from the base rather than MatterBaseTest. Can you open up a follow up issue to fix this up? IMO it does make sense to have CommissioningDeviceTest derive from the MatterBase test. I think the circular include might need to be solved in the other direction. |
cecille
approved these changes
Jul 14, 2025
|
Hi @andy31415 do you have any remaining questions or concerns on this PR before it can be merged? |
LyudmilaKostanyan
pushed a commit
to LyudmilaKostanyan/connectedhomeip
that referenced
this pull request
Jul 16, 2025
* Add checking for CommissionDeviceTest inside runner.py run_tests_no_exit method * Update src/python_testing/matter_testing_infrastructure/chip/testing/runner.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Removed get_test_info call from run_tests_no_exit, since it seems not being used --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the call
get_test_info(test_class, matter_test_config)since it doesn't seem to be doing anything in this context.Related issues
project-chip/certification-tool#652
Testing
Running the following command successfully:
python3 /root/python_testing/scripts/sdk/TC_CADMIN_1_11.py --commissioning-method on-network --trace-to json:log --discriminator 3840 --passcode 20202021
Running using TH client successfully (Commissioning):
python3 /root/python_testing/scripts/sdk/matter_testing_infrastructure/chip/testing/test_harness_client.py commission --trace-to json:log --commissioning-method on-network --discriminator 3840 --passcode 20202021 --storage_path /root/python_testing/admin_storage2.json
Running using TH client successfully (Test Execution):
python3 /root/python_testing/scripts/sdk/matter_testing_infrastructure/chip/testing/test_harness_client.py sdk/TC_ACE_1_3 TC_ACE_1_3 --tests test_TC_ACE_1_3 --trace-to json:log --in-test-commissioning-method on-network --discriminator 3840 --passcode 20202021