Address post-review comments from AdministratorCommissioning cluster code migration #39971
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses post-merge feedback by fixing a typo in a comment and renaming a function for better consistency with its corresponding cluster attribute. The changes are straightforward and improve the code's clarity. I have one minor suggestion to further enhance maintainability.
src/app/clusters/administrator-commissioning-server/AdministratorCommissioningLogic.h
Show resolved
Hide resolved
|
PR #39971: Size comparison from 8c26caa to 6ee6f8a Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
soares-sergio
approved these changes
Jul 14, 2025
woody-apple
approved these changes
Jul 15, 2025
LyudmilaKostanyan
pushed a commit
to LyudmilaKostanyan/connectedhomeip
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address post-merge comments from #39470. The
.Raw()usage was already addressed, so fixed the typo and adjusted one naming.Testing
No functional changes in this PR. Compile/existing tests should be sufficient.