[SoilMeasurement] Move value validation and added initial value for all-clusters #39993
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
examples/all-clusters-app/all-clusters-common/src/soil-measurement-stub.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #39993: Size comparison from ad2e3f5 to bebf758 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR address the issue that all-clusters does not set an initial measure ment value and was null untill a simulated measurement was performed.
The change does an initial set of the measured value equal to the minimum measurement value.
The PR also moves the value validation into the server in stead of only have it on the hadling for simulated measurements. This means it is not possible to set a value which is not within the min and max range on the server.
Related issues
Fixes #39738
Testing
Verified all-clusters did not fail with no initial simulated measuremet was not done.
Verified the value validation with multiple invalid and valid initial values as well as by perfoming simulated measurements with valid and invalid values.