[SoilMeasurement] Fix misspell and add reporting test steps in SOIL-2.2 #39994
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReneJosefsen
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a copy-paste error in a test step description and adds new test steps to verify attribute reporting for the Soil Measurement cluster. The implementation for the new reporting steps is sound, but I've suggested a small improvement to make the report validation more robust against potential KeyError exceptions. Overall, the changes are well-aligned with the stated goals.
|
PR #39994: Size comparison from ad2e3f5 to d1ef7e3 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #39994: Size comparison from ad2e3f5 to 242b2bb Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a misspell where min was wrongly references for the max limit
The PR also adds reporting test steps, the TP change is https://github.com/CHIP-Specifications/chip-test-plans/pull/5340
Related issues
The editorial is mentioned in #39738 but is tracked as a TP issue in https://github.com/CHIP-Specifications/chip-test-plans/pull/5320
Testing
Locally executed TC-SOIL-2.2 to validate the reporting test steps.