-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[silabs] Add zephyr examples platform code #40001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[silabs] Add zephyr examples platform code #40001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the base platform code for supporting Zephyr with Silicon Labs parts. This includes base classes for application tasks and CLI, a device manager, and callback handlers. The changes are extensive as they introduce a new platform layer.
My review focuses on correctness, maintainability, and adherence to the project's style. I've found a critical issue that will cause a compilation failure due to a re-defined variable. I've also pointed out several typos in comments and a function name, a potential robustness issue in CLI command parsing, and some unreachable code. Applying these suggestions should improve the quality and robustness of the new platform code.
examples/platform/silabs/zephyr/include/CommonDeviceCallbacks.h
Outdated
Show resolved
Hide resolved
PR #40001: Size comparison from 1283920 to 4498114 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
4498114
to
9672f62
Compare
PR #40001: Size comparison from e560a10 to 9672f62 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/platform/silabs/zephyr/include/CommonDeviceCallbacks.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving platofmr-specific example directory with platform maintainer approval. Left some comments though - I am unclear on the building, layout (do we want include/source separation and given zephy why do we separate what seems to try to be more generic) and usage of app-specific defines in code that seems to want to be more general.
9672f62
to
ccaf507
Compare
PR #40001: Size comparison from bad5961 to ccaf507 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* add zephyr examples platform code * apply comments * fix comments
Summary
Add the base platform code needed to support Zephyr with Silabs parts
not able to compile yet on CSA repo as this is PR 3 of 4
Related issues
None
Testing
Tested internally at Silicon Labs