[Silabs] Removing the warning flags for 917SoC #40003
Open
+6
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused variables for the 917 SoC to fix compiler warnings. The changes across all files correctly address this by either removing the variables, moving them to the correct scope, or using [[maybe_unused]]. A potential bug was identified in OTAImageProcessorImpl::HandleProcessBlock where error return codes are not being checked.
|
PR #40003: Size comparison from e560a10 to 5079474 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
selissia
approved these changes
Jul 15, 2025
|
PR #40003: Size comparison from f634285 to ded561f Full report (5 builds for cc32xx, stm32, tizen)
|
|
PR #40003: Size comparison from f634285 to ed758b3 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -106,7 +106,9 @@ typedef struct | |||
| uint8_t public_key[2 * NUM_ECC_BYTES]; | |||
| } mbedtls_uecc_keypair; | |||
|
|
|||
| #if !(SLI_SI91X_MCU_INTERFACE) | |||
There was a problem hiding this comment.
This is the SiWX specific file - when would this define not be set?
There was a problem hiding this comment.
this was kept, if trng from hardware is not used, for future usage/device where trng is not supported.
There was a problem hiding this comment.
I'm not sure i understand the comment - the define is the 917 SoC and that platform is the only to use that file if i am not mistaken?
There was a problem hiding this comment.
okay, so if a platform doesn't support H/W TRNG and wanted to use the tinycrypt then this can be borrowed.
jmartinez-silabs
added
the
changing-submodules-on-purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were multiple unused variable for the 917 SoC
Removing the flags and fixing the warning
Updating the submodule to fix the build for BRD4342A boards.
Testing
Local build for the 917 SoC.