Remove temporary aliases from matter testing.py #40004
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring to improve code clarity by removing temporary aliases and using fully qualified names instead. The changes are extensive and mostly correct. However, I've identified a few critical issues, including typos and an incorrect function call that was likely introduced during the refactoring. Additionally, the core goal of removing the temporary aliases from matter_testing.py has not been fully completed, as the alias definitions still remain. Please address these points to ensure the stability and completeness of the refactoring.
| @@ -182,7 +182,7 @@ async def test_TC_TIMESYNC_2_8(self): | |||
| self.print_step(22, "Read LocalTime") | |||
| if dst_list_size > 1: | |||
| local = await self.read_ts_attribute_expect_success(local_attr) | |||
| compare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5)) | |||
| timeoperations.ompare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5)) | |||
There was a problem hiding this comment.
There is a typo in the function name. It should be compare_time instead of ompare_time.
| timeoperations.ompare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5)) | |
| timeoperations.compare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5)) |
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
abalestra22
force-pushed
the
remove_temporary_aliase_from_matter_testing.py
branch
from
3d27b4c to
05114c1
Compare
|
Remove submodules from git history please. |
|
Remove submodules from git history please. |
abalestra22
force-pushed
the
remove_temporary_aliase_from_matter_testing.py
branch
from
aace022 to
c10a82e
Compare
Summary
Refactored matter_testing.py to remove all temporary function aliases from the matchers, timeoperations, conversions, and decorators modules. Replaced all alias usages with fully qualified module paths (e.g., matchers.assert_success instead of assert_success). This change ensures better code readability, avoids ambiguity, and aligns with the module-level organization standards defined for the project.
Related issues
Fixes: #37537
Testing
Refactored Python tests