[Darwin] Track last commissioining stage for metrics #40010
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves commissioning metrics on Darwin by preventing the kCleanup stage from overwriting the actual final commissioning stage. The change correctly ignores the cleanup stage, which is particularly useful for diagnosing failures. The review suggests using a safer string comparison and simplifying the conditional logic to improve robustness and readability.
|
PR #40010: Size comparison from d8d0bc6 to abe4493 Full report (6 builds for cc32xx, nrfconnect, stm32)
|
- Since kCleanup is always called during commissioining it ends up being the last stage tracked. This fix is to ignore this stage and track the last stage committed as part of commissioining. Fixes project-chip#40009
anush-apple
force-pushed
the
metrics-track-last-stage
branch
from
abe4493 to
f3b0767
Compare
|
PR #40010: Size comparison from 3eac2cc to a0898e8 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #40010: Size comparison from 3eac2cc to 2efc217 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
CI didn't pass on first try due to #40132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines