docs: use ParamSpec in "Declaring decorators" #13237
Conversation
|
While the documented approach is valid for the common case of a decorator which doesn't change the function type, and as the docs say the |
| @@ -553,16 +552,17 @@ Here's a complete example of a function decorator: | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| from typing import Any, Callable, TypeVar, cast | |||
| from typing import Callable, ParamSpec, TypeVar | |||
There was a problem hiding this comment.
I think that we should include both examples. Because both techniques are quite common. This way we can clearly show why ParamSpec is better.
What do you think?
There was a problem hiding this comment.
@sobolevn Check it out now. I've re-introduced the non-ParamSpec example, and also added an example where we change the return type (to show where ParamSpec is actually useful beyond "avoiding casts" type pure-ism).
|
Let's wait for a bit, maybe @srittau or @JelleZijlstra have some feedback? |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Resolves #12983.