Skip to content

[stubgen] Fix UnpackType for 3.11+ #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 6, 2025

Don't replace *Ts with Unpack[Ts] on Python 3.11+.
This is broken currently since Unpack isn't added as import in the stub file.

@cdce8p cdce8p added topic-stubgen topic-pep-646 PEP 646 (TypeVarTuple, Unpack) labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 306c1af into python:master Jan 7, 2025
19 checks passed
@cdce8p cdce8p deleted the stubgen-unpack branch January 7, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-pep-646 PEP 646 (TypeVarTuple, Unpack) topic-stubgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants