Don't make underscored attributes as enum members #8302

TH3CHARLie · 2020-01-17T06:22:28Z

From @JelleZijlstra 's description, for underscored attributes, we don't make them as enum members

bluetech · 2020-01-17T11:41:17Z

A bit silly, but the output of this program

import enum

class E(enum.Enum):
    _ = 1
    __ = 2
    ___ = 3
    ____ = 4
    _____ = 5
    __a__ = 6

print([e.value for e in E])

is [1, 2, 3, 4, 5], but your check if name.startswith('__') and name.endswith("__") rejects 2, 3, 4 and 5 😄

TH3CHARLie · 2020-01-17T12:14:44Z

print([e.value for e in E])

Good catch, I wouldn't think anyone would write code like this but it is definitely a valid case, thanks!

JukkaL

Looks great! Thanks for also refactoring the code into a new function. It makes the code easier to read and understand.

TH3CHARLie added 3 commits January 17, 2020 14:18

don't make underscored attributes as enum members

e504271

update testcase

9a262d3

Merge branch 'master' into fix-5312

bf7eb97

TH3CHARLie requested review from Michael0x2a, JukkaL and ilevkivskyi January 17, 2020 06:23

fix

279699e

JukkaL approved these changes Jan 17, 2020

View reviewed changes

JukkaL merged commit 861f01c into python:master Jan 17, 2020

TH3CHARLie deleted the fix-5312 branch January 17, 2020 13:44

Provide feedback