Skip to content

Report an error if final class has abstract attributes #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2020
Merged

Report an error if final class has abstract attributes #8332

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6094e30
Report an error if final class has abstract attributes
dhalenok Jan 25, 2020
96655a5
Add test for final class with abstract attributes
dhalenok Jan 26, 2020
bc1d0b5
Update docs to mention final class with abstract attributes
dhalenok Jan 26, 2020
d17375e
Change docs location of final class with abstract attributes
dhalenok Jan 26, 2020
aa07545
Add additional tests for final class with abstract attributes
dhalenok Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add additional tests for final class with abstract attributes
  • Loading branch information
@dhalenok
dhalenok committed Jan 26, 2020
commit aa07545bcc5553c7038af8f351c5b42657a52c1f
30 changes: 30 additions & 0 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6694,3 +6694,33 @@ class A(metaclass=ABCMeta): # E: Final class __main__.A has abstract attributes
pass

[builtins fixtures/property.pyi]

[case testFinalClassWithoutABCMeta]
from abc import abstractmethod
from typing import final

@final
class A(): # E: Final class __main__.A has abstract attributes "bar", "foo"
@abstractmethod
def foo(self):
pass

@property
@abstractmethod
def bar(self):
pass

[builtins fixtures/property.pyi]

[case testFinalClassInheritedAbstractAttributes]
from abc import abstractmethod, ABCMeta
from typing import final

class A(metaclass=ABCMeta):
@abstractmethod
def foo(self):
pass

@final
class B(A): # E: Final class __main__.B has abstract attributes "foo"
pass