Fixed catching warnings #8505
Merged
Fixed catching warnings #8505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Feb 1, 2025
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Feb 1, 2025
fdintino
pushed a commit
to fdintino/Pillow
that referenced
this pull request
Feb 3, 2025
* Removed skip_unless_feature on methods when class is already skipped * Test speed less than slowest and greater than fastest * Updated type hints * Only access angle when AVIF_TRANSFORM_IROT flag is present * Added AVIF_ROOT * Only define normalize_quantize_value if it will be used * Build libavif after libjpeg * Use rgb.rowBytes in overflow check * Group EXIF info * Removed __loaded * If brew is not installed, use /usr prefix * Sort AVIF codecs alphabetically * Updated rav1e license * Fixed catching warning, as per python-pillow#8505 * Simplified code * Fixed typos * Test further scenarios * Use y* to parse bytes --------- Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.pytest.org/en/latest/how-to/capture-warnings.html#additional-use-cases-of-warnings-in-tests states
However, in #6076, I decided not to add
warnings.simplefilter("error"). I've now concluded that was a mistake, and that this doesn't turn warnings into errors as intended - if I addwarnings.warn("This should cause a failure"), the test suite still passes. Restoringsimplefilter, only then does it fail like it should.