Skip to content

Don't call make clean or pip in tox #8754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2025
Merged

Don't call make clean or pip in tox #8754

merged 1 commit into from
Feb 15, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 15, 2025

https://github.com/tox-dev/tox-uv is a tox plugin that uses uv instead of pip. By default, it doesn't install pip into the tox virtualenv.

We don't actually need to call pip install . here, because tox itself installs Pillow into its virtualenv.

And we don't need to run make clean either, because again tox installs into its own virtualenv, and the .so files are found at paths like:

./.tox/py313/lib/python3.13/site-packages/PIL/_imagingmath.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_imaging.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_webp.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_imagingcms.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_imagingft.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_imagingmorph.cpython-313-darwin.so
./.tox/py313/lib/python3.13/site-packages/PIL/_imagingtk.cpython-313-darwin.so

And not like these that pip install . creates:

./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imagingmath.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imaging.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_webp.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imagingcms.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imagingft.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imagingmorph.cpython-313-darwin.so
./build/lib.macosx-10.13-universal2-cpython-313/PIL/_imagingtk.cpython-313-darwin.so

@hugovk hugovk added the Testing label Feb 15, 2025
@radarhere radarhere merged commit 0364cfd into python-pillow:main Feb 15, 2025
51 checks passed
@hugovk hugovk deleted the update-tox branch February 15, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @radarhere