Skip to content

Call startswith/endswith once with a tuple, and range without start=0 #8799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Call startswith/endswith once with a tuple, and range without start=0 #8799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f4beb4
Lint with flake8-pie
hugovk Mar 3, 2025
e4cac21
Don't use start=0 in range()
hugovk Mar 3, 2025
a2b13cc
Call startswith/endswith once with a tuple
hugovk Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Lint with flake8-pie
  • Loading branch information
@hugovk
hugovk committed Mar 3, 2025
commit 1f4beb4a5c5724019ea9b0683432cbc3357d10cc
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ lint.select = [
"ISC", # flake8-implicit-str-concat
"LOG", # flake8-logging
"PGH", # pygrep-hooks
"PIE", # flake8-pie
"PT", # flake8-pytest-style
"PYI", # flake8-pyi
"RUF100", # unused noqa (yesqa)
Expand All @@ -133,6 +134,7 @@ lint.ignore = [
"E221", # Multiple spaces before operator
"E226", # Missing whitespace around arithmetic operator
"E241", # Multiple spaces after ','
"PIE790", # flake8-pie: unnecessary-placeholder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, you're ignoring this because you dislike the rule? I mean, we could adjust to it. hugovk#130

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's clearer with an explicit pass.

"PT001", # pytest-fixture-incorrect-parentheses-style
"PT007", # pytest-parametrize-values-wrong-type
"PT011", # pytest-raises-too-broad
Expand Down