Do not convert BC1 LUT to UINT32 #8837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 29, 2025
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 29, 2025
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 29, 2025
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 29, 2025
hugovk
pushed a commit
that referenced
this pull request
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pillow/src/libImaging/BcnDecode.c
Lines 43 to 49 in b8abded
Pillow/src/libImaging/BcnDecode.c
Lines 106 to 109 in b8abded
With a little maths and changing the loop of size 16 to two range loops of size 4 each, this code can be changed to avoid the UINT32. If you think that changing the size of the loop is misleading to the reality of the image, it's not - looking at https://learn.microsoft.com/en-us/windows/win32/direct3d10/d3d10-graphics-programming-guide-resources-block-compression#bc1, you can see that the LUT is actually representing a 4x4 block.