Allow cmake<4 when building libavif and libtiff #8851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Apr 1, 2025
radarhere
changed the title
|
We still have some libavif failures on Windows: https://github.com/python-pillow/Pillow/actions/runs/14192343380/job/39759659022#step:19:2739 |
|
They mysteriously reverted to the 20250309.1.0 runner image. I reran the jobs and they passed this time. If you'd like, #8855 adds |
|
Thanks! Good to know we can restart it and hopefully get the newer runner. I'll go ahead with the release without merging it to save a bunch of CI time, but we can merge it afterwards if we see it pop up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtiff has started failing to build in main on WIndows - https://github.com/python-pillow/Pillow/actions/runs/14187037544/job/39744130790
This would be due to the recent release of cmake 4 - https://github.com/Kitware/CMake/releases/tag/v4.0.0
https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features