Skip to content

Removed condition that is always true #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Removed condition that is always true #8862

merged 1 commit into from
Apr 3, 2025

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Apr 2, 2025 •
edited
Loading

https://github.com/python-pillow/Pillow/actions/runs/14220077307/job/39845672092#step:10:365

src/_avif.c:571:10: warning: address of 'rgb' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&rgb) {
~~ ^~~

cc @fdintino

fdintino
fdintino approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@fdintino fdintino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I think this got added in the refactor that added the goto; I noticed the warning and had intended to fix it, but it slipped my mind.

@hugovk hugovk merged commit 2d452c8 into python-pillow:main Apr 3, 2025
56 checks passed
@radarhere radarhere deleted the avif_rgb branch April 3, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdintino fdintino fdintino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radarhere @fdintino @hugovk