Skip to content

WebUI: Default select & Remember files for rename #22864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

userwiths
Copy link
Contributor

Closes #22851

Changes summary

This PR is meant to introduce 2 behavioral changes in the WebUI.

  1. Upon opening Rename files dialog, all files will be selected by default.
  2. After a rename, selection will remain as is.

Use cases

  1. Opening the Rename files usually entails the rename of multiple files, as stated by OP in the issue. So it makes more sense to have all files selected by default, and allow the user to deselect some of them.
  2. Another common use case (for the second change) is for replacement of multiple different terms in filenames that follow some schema (adding the video format in the name of each file for example). So in that use case it makes sense to keep the selection after renaming the files.

Issues

  1. There was an explicit removal of renamed files from selection. There might have been some other discussion or intent behind this removal that im unaware of.
  2. I personally dont like the invocation of the .click() function, don't have a better idea at the moment tho. Also the state of the checkbox is determined by the state of the files, not vice verca which confused me enough to settle for a simulated click. If you think its good idea to change that logic, and make it so its an event (file select) that affects the global checkbox, rather than looping through all nodes in the tree, im willing to give it a try.

@xavier2k6 xavier2k6 added the WebUI WebUI-related issues/changes label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebUI: Remember Multi-Rename settings doesn't remember file selection
2 participants