WebUI: Default select & Remember files for rename #22864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22851
Changes summary
This PR is meant to introduce 2 behavioral changes in the WebUI.
Rename files
dialog, all files will be selected by default.Use cases
Rename files
usually entails the rename of multiple files, as stated by OP in the issue. So it makes more sense to have all files selected by default, and allow the user to deselect some of them.Issues
.click()
function, don't have a better idea at the moment tho. Also the state of the checkbox is determined by the state of the files, not vice verca which confused me enough to settle for a simulated click. If you think its good idea to change that logic, and make it so its anevent
(file select) that affects the global checkbox, rather than looping through all nodes in the tree, im willing to give it a try.