WebUI: Add value constraint checks #22911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
userwiths
force-pushed
the
fix/missing-value-constraint-checks
branch
from
32aab54 to
1e55b13
Compare
|
@userwiths |
userwiths
force-pushed
the
fix/missing-value-constraint-checks
branch
from
1e55b13 to
8a61031
Compare
glassez
changed the title
Chocobo1
reviewed
Jun 28, 2025
Chocobo1
approved these changes
Jul 12, 2025
|
@userwiths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22758.
Other preferences like
Listening Port&announcePorthave an explicit check in the JS inpreferences.html.It seems that a few fields however were lacking such checks those fields being:
I tested manually those fields and was able to save values above the allowed from the WebUI, which were visualizing as the maximum allowed value in the QT App but remained above those values even after restart according to WebUI.