Skip to content

WebUI: Support managing category download path #22938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025

Conversation

Piccirello
Copy link
Member

Screenshot 2025-06-27 at 22 46 22

@Piccirello Piccirello added this to the 5.2 milestone Jun 28, 2025
@Piccirello Piccirello requested a review from a team June 28, 2025 06:11
@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Jun 28, 2025
@Piccirello Piccirello force-pushed the webui-category-download-path branch 2 times, most recently from 0ce0744 to 827fa5a Compare June 28, 2025 06:16
@Piccirello Piccirello force-pushed the webui-category-download-path branch from a944ccc to 834d51c Compare June 28, 2025 20:07
@glassez glassez requested a review from Chocobo1 July 1, 2025 07:30
@thalieht
Copy link
Contributor

thalieht commented Jul 1, 2025

When "Use another path for incomplete torrents" in qBt settings is checked and the corresponding choice in this dialog is

  1. "Default": It should fill the (disabled) field with the incomplete save path that will be used (now it's empty)
  2. "Yes": This is just a suggestion because currently it follows the GUI behavior. When the incomplete save path has not been overwritten here, IMO it should also fill the field with actual text and not just placeholder text with the incomplete save path that will be used. Why? I think it's easier to change a part of the path than to write the whole thing. I doubt that people type drastically different save paths often where the current way is more convenient.

@glassez
Copy link
Member

glassez commented Jul 2, 2025

2. IMO it should also fill the field with actual text and not just placeholder text with the incomplete save path that will be used.

Note that it now allows you to override whether or not an incomplete path is used without specifying a path itself (i.e. use default incomplete path).

@Piccirello
Copy link
Member Author

When "Use another path for incomplete torrents" in qBt settings is checked and the corresponding choice in this dialog is

  1. "Default": It should fill the (disabled) field with the incomplete save path that will be used (now it's empty)

Fixed! Another good catch.

  1. "Yes": This is just a suggestion because currently it follows the GUI behavior. When the incomplete save path has not been overwritten here, IMO it should also fill the field with actual text and not just placeholder text with the incomplete save path that will be used. Why? I think it's easier to change a part of the path than to write the whole thing. I doubt that people type drastically different save paths often where the current way is more convenient.

I agree with this. I've switched the behavior.

Note that it now allows you to override whether or not an incomplete path is used without specifying a path itself (i.e. use default incomplete path).

This is true, though I think it's not intuitive for users. They may not expect that leaving the field blank will use the default path. At first I thought it was a bug that the GUI allowed using a blank path, until I looked at the code.

@Piccirello Piccirello force-pushed the webui-category-download-path branch from 834d51c to 079e3d4 Compare July 2, 2025 21:41
@glassez
Copy link
Member

glassez commented Jul 3, 2025

This is true, though I think it's not intuitive for users. They may not expect that leaving the field blank will use the default path.

If so, wouldn't it be better to simply add some explanation label next to it rather than making this feature inaccessible?

@Piccirello
Copy link
Member Author

This is true, though I think it's not intuitive for users. They may not expect that leaving the field blank will use the default path.

If so, wouldn't it be better to simply add some explanation label next to it rather than making this feature inaccessible?

The feature is still accessible, the user just has to delete the existing pre-filled value before submitting the form.

@glassez
Copy link
Member

glassez commented Jul 3, 2025

The feature is still accessible, the user just has to delete the existing pre-filled value before submitting the form.

IMO, this is less intuitive than the opposite action (fill in the field if you want to explicitly set the path).

@Piccirello
Copy link
Member Author

The feature is still accessible, the user just has to delete the existing pre-filled value before submitting the form.

IMO, this is less intuitive than the opposite action (fill in the field if you want to explicitly set the path).

Both are pretty unintuitive. For now I'll keep the WebUI's behavior matching the GUI and then someone can improve both if they'd like.

@Piccirello Piccirello force-pushed the webui-category-download-path branch from 079e3d4 to 6b5faba Compare July 3, 2025 11:45
@glassez
Copy link
Member

glassez commented Jul 3, 2025

I think it's easier to change a part of the path than to write the whole thing. I doubt that people type drastically different save paths often

IMO, in most cases, the default path is sufficient for the user, which has the format <base_path>/<category_name>. However, we provide the option to enable or disable it for specific categories.

@thalieht
Copy link
Contributor

thalieht commented Jul 4, 2025

I think it's easier to change a part of the path than to write the whole thing. I doubt that people type drastically different save paths often

IMO, in most cases, the default path is sufficient for the user, which has the format <base_path>/<category_name>. However, we provide the option to enable or disable it for specific categories.

I don't understand what you said is related.
Anyway i hadn't thoroughly thought that when the field is filled it means that the user changed the path explicitly.

This allows iframes to access these values without having to re-fetch them.
@Piccirello Piccirello force-pushed the webui-category-download-path branch from 6b5faba to f45f523 Compare July 6, 2025 21:52
@Piccirello
Copy link
Member Author

Piccirello commented Jul 6, 2025

Rebased onto master now that #22958 is merged. This PR now only contains the changes to the WebUI.

thalieht
thalieht previously approved these changes Jul 7, 2025
@Piccirello Piccirello requested a review from glassez July 9, 2025 02:50
@glassez

This comment was marked as off-topic.

@Piccirello

This comment was marked as off-topic.

@Chocobo1 Chocobo1 merged commit 7aebd07 into qbittorrent:master Jul 14, 2025
15 checks passed
@Chocobo1
Copy link
Member

@Piccirello
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants