-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Encode search results as JSON #22971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
quick test, don't get any published date for limetorrents/piratebay - haven't cross referenced against release/master. |
I don't have strong opinion on this change but you must know this: https://github.com/qbittorrent/search-plugins/wiki/How-to-write-a-search-plugin#search-results-format |
It's not a problem to update the Wiki. It also wouldn't be a very big problem to support both formats at this stage. |
👍
If possible, qbt can support both formats and log a warning message if the old format was used/detected. This would encourage plugin authors to update to the new format and ensure no breakage. The old format would be supported for one or two major releases and dropped afterwards.
I hope you would ensure the 'official' plugins will still be working (by updating them if needed).
How are you going to know it beforehand? I suppose you will have to break it first and then receive feedback. |
Perhaps some of the community's active members will speak about this in advance.
This is not a problem if it is limited to this change. However, if we go further, maintaining backward compatibility may become too cumbersome. |
How about adding a version tag, for example |
Encoding results as JSON objects makes them more flexible.