src/bootchooser: add support for efibootguard #1450
Conversation
Add bootchooser support for efibootguard. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
| // TODO add efibootguard bootchooser tests | ||
|
|
||
| // Getting slots: | ||
| // TODO call "bg_printenv --raw --part=1" & return k=>v array |
There was a problem hiding this comment.
Remove these lines.
| @@ -1456,6 +1458,326 @@ static gboolean efi_get_state(RaucSlot* slot, gboolean *good, GError **error) | |||
| return TRUE; | |||
| } | |||
|
|
|||
| // TODO add efibootguard bootchooser tests | |||
There was a problem hiding this comment.
Need to add some tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // #define BG_PRINTENV_NAME "bg_printenv" | ||
| // #define BG_SETENV_NAME "bg_setenv" |
Check notice
Code scanning / CodeQL
Commented-out code Note
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (2.72%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
- Coverage 81.95% 80.98% -0.98%
==========================================
Files 67 67
Lines 20093 20408 +315
==========================================
+ Hits 16467 16527 +60
- Misses 3626 3881 +255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| g_ptr_array_add(sub_args, g_strdup(slot)); | ||
| g_ptr_array_add(sub_args, NULL); | ||
|
|
||
| sub = r_subprocess_newv(sub_args, G_SUBPROCESS_FLAGS_STDOUT_PIPE | G_SUBPROCESS_FLAGS_STDERR_MERGE, &ierror); |
There was a problem hiding this comment.
makes sense to rework this function to get of the data all at once perhaps returning a struct
jluebbe
added
the
enhancement
|
This would need to be rebased, as #1636 has split the bootloader backends into different files. |
Add bootchooser support for efibootguard.
Draft for now, for some early feedback.
Fixes #1443