Cleanup dangling bundle mount point before install. #1678
Conversation
If rauc install process is terminated, the next run will fail with the following error: Failed mounting bundle: Failed to create dm device: Device or resource busy The cause is the bundle from previous run is still mounted. This patch address this issue by check bundle mount point and unmount dangling bundle. Signed-off-by: Zixun LI <zli@ogga.fr>
|
Do we really want to clean up automatically here? This could also be a concurrently running RAUC process. As this is an unexpected state, I'd prefer to abort instead of silently trying to fix it. |
|
I think it's just a variant of what I raised my concerns about in #1676 (comment). Thus, agreed to what @jluebbe noted. |
Currently is there no locking for concurrent protection ? I think multiples install from the same bundle will not end up well...
A fixup is needed otherwise following update will fail forever. Maybe what you prefer is an explicit cleanup mode ? @ejoerns in #1676 the main concern is identification of previous used DM devices, here the bundle mount points stays the same. |
|
In the service case, locking is internal and cleanup is handled by using a mount namespace. For the non-service case, cleanup (perhaps also using an |
If rauc install process is terminated, the next run will fail with the following error:
Failed mounting bundle: Failed to create dm device: Device or resource busyThe cause is the bundle from previous run is still mounted. This patch address this issue by check bundle mount point and unmount dangling bundle.
Fix #1676