src/main: add '--list' option to write-slot command #1717
Conversation
ejoerns
added
the
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1717 +/- ##
=======================================
Coverage 84.50% 84.51%
=======================================
Files 76 76
Lines 22380 22390 +10
=======================================
+ Hits 18912 18922 +10
Misses 3468 3468
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .TP | ||
| \fB\-C\fR, \fB\-\-list\fR | ||
| list available slots and exit. | ||
|
|
There was a problem hiding this comment.
I find options which completely replace a command's behavior confusing.
There was a problem hiding this comment.
like --help?
I thought explicitly noting this in the help text might make it clear, though.
You'd prefer write-image list? Or a separate command? A separate command would render the idea behind this useless I guess.
There was a problem hiding this comment.
rauc status already lists the available slots. If that is confusing, we should improve it instead of adding something to write-slot.
There was a problem hiding this comment.
For rauc being compiled with service support (which is the default), rauc status requires the service to run, which write-slot doesn't. For use as a standalone tool, which is more or less the intention of write-slot, I still find it useful to have a built-in way to list the slots. Not necessarily a --list option if this is too controversial.
This should make it more convenient to use write-slot since it does not require navigating through the more complex 'rauc status' output or looking into the system.conf. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
This should make it more convenient to use
write-slotsince it does not require navigating through the more complexrauc statusoutput or looking into thesystem.conf.