-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
C-enhancementCategory: Enhancement or feature requestCategory: Enhancement or feature request
Description
#1081 has been stuck for a while, so I tried implementing my own version.
Preview the search functionality online
Inspired by #1496.
Major implementation steps:
- Land Add non-English search support #2392
- Fix buggy teaser (preview) 1
- Keyword highlighting doesn't work as expected for Chinese
- The selected range displayed as teaser sometimes contains no keywords at all (the target chapter does contain the keyword though)
- Enhance mixed multi language search support
- Implement a "fallback" strategy for text in mixed languages (detail)
- Fix buggy teaser (preview) 1
- Support Emoji search
- Fix
elasticlunr-rs
's indexing implemantation (detail)
- Fix
- Localize UI rendered by HTML renderer
Unresolved questions:
Should(Not likely, since it causes severe binary size bloat)search-non-english
feature be enabled by default?- Should each supported language have an individual feature flag? Would it make the feature flag list too noisy?
- Should we consider other search solutions than elasticlunr.js & lunr-languages?
- Should the new "fallback" search implementation apply to English books as well?
Footnotes
ShaoyenYu, zjp-CN, fawkesLi-lhh, hellboy-hub, s1rius and 10 moreShaoyenYu, PigsyAK and ali50m
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: Enhancement or feature requestCategory: Enhancement or feature request