Skip to content

Fix missing json.Unmarshal error check #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sashabaranov
Copy link
Owner

Summary

  • check error from json.Unmarshal when preparing extra request body
  • test the unmarshal error is returned

Testing

  • go vet ./...
  • go test ./...

https://chatgpt.com/codex/tasks/task_e_68715d61a164832584ed7f158df96435

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.45%. Comparing base (181c0e8) to head (74a7c86).

Files with missing lines Patch % Lines
embeddings.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   99.59%   99.45%   -0.14%     
==========================================
  Files          34       34              
  Lines        2205     2206       +1     
==========================================
- Hits         2196     2194       -2     
- Misses          6        8       +2     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant