Add starlite to the doc navigation list
#3082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #3081 |
Closed
|
Hi 👋 You can find a preview of the docs here: |
patrick91
reviewed
Sep 7, 2023
docs/README.md
Outdated
| @@ -80,6 +80,7 @@ | |||
| - [Sanic](./integrations/sanic.md) | |||
| - [Chalice](./integrations/chalice.md) | |||
| - [Starlette](./integrations/starlette.md) | |||
| - [Starlite](./integrations/starlite.md) | |||
There was a problem hiding this comment.
I think it might be worth renaming the page and link to litestar, since they changed name 😊
|
Seems to work 🎉
|
patrick91
reviewed
Sep 7, 2023
Comment on lines
+16
to
+17
| from litestar import Litestar | ||
| from strawberry.litestar import make_graphql_controller |
There was a problem hiding this comment.
oh, we haven't updated the code yet, if you wanna do that to we should do an alias from the old name and do a deprecation, I'm also fine with just updating the docs for now
There was a problem hiding this comment.
I've got to switch to $dayjob now. I might be able to get to that this weekend but I'm happy for you to add the necessary changes here or merge this and add the changes in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist