Skip to content

Release 1.1.0 #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Release 1.1.0 #2367

merged 1 commit into from
Mar 31, 2019

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Mar 20, 2019

Here's the changelog for the next release. Edit rights are granted, so if anything is wrong, feel free to fix it.

Resolves #2349

Allegedly there are still issues with the Twitch plugin and embedded ads. Maybe we should wait for that to resolve first if it's not a false alarm. Still waiting for a proper bug report by one of the people who are running into this issue...

@gravyboat
Copy link
Member

@bastimeyer Thanks for putting this together. I saw the report about people still having issues as well but it seems like that might be due to people using out of date plugins? It's hard to tell. Did you manually generate lines 14-61? That was the portion that wasn't being created for me.

@bastimeyer
Copy link
Member Author

Did you manually generate lines 14-61

Yes, I didn't run that script, because I have my remotes named differently and it's hardcoded. It simply runs

git shortlog --email --no-merges --pretty=%s ${LAST_TAG_NAME}..

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2367 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2367   +/-   ##
=======================================
  Coverage   52.59%   52.59%           
=======================================
  Files         237      237           
  Lines       14802    14802           
=======================================
  Hits         7785     7785           
  Misses       7017     7017

1 similar comment
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2367 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2367   +/-   ##
=======================================
  Coverage   52.59%   52.59%           
=======================================
  Files         237      237           
  Lines       14802    14802           
=======================================
  Hits         7785     7785           
  Misses       7017     7017

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2367 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2367   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files         238      238           
  Lines       14961    14961           
=======================================
  Hits         7876     7876           
  Misses       7085     7085

@laurencee
Copy link

laurencee commented Mar 29, 2019

The twitch ads PR #2372 is probably the highlight for this release, lots of people (myself included) are excited for that 👍

@bastimeyer
Copy link
Member Author

Rebased the PR and updated the changelog...
This release doesn't necessarily have to happen today, but everything should be ready so far (except the empty stream player issue when filtering out twitch ads)

@bastimeyer
Copy link
Member Author

The codecov spam and mislabeled coverage reduction is getting really annoying. This is caused by Appveyor, btw...

@bastimeyer
Copy link
Member Author

Any concerns here? If not, I'll update the release date once more later today, then merge the changes and push the 1.1.0 tag.

@gravyboat
Copy link
Member

gravyboat commented Mar 30, 2019

@bastimeyer No I think we are good, do you want to get in #2387 and #2386? If not we can do them on the next release.

@bastimeyer
Copy link
Member Author

The plugin bugfix can/should be merged. I'll wait for that until this evening or tomorrow, in case somebody else want to verify the changes first. The Twitch plugin cleanup can be done after the release (with some more cleanups).

If you want to do it instead, go head. I've updated the date of the changelog, so all you'll have to do is merge this PR and add+push the 1.1.0 tag afterwards.

@gravyboat gravyboat merged commit f652742 into streamlink:master Mar 31, 2019
@gravyboat
Copy link
Member

gravyboat commented Mar 31, 2019

Merged this then opened up #2391 because of the changelog append (couldn't push directly to master), then tagged 1.1.0 and pushed that, should be all set to go. Thanks for your hard work @bastimeyer.

@bastimeyer
Copy link
Member Author

The PyPI deploy job failed:
https://travis-ci.org/streamlink/streamlink/jobs/513828143#L3637
https://pypi.org/project/streamlink/#files

This means that there are no win32 and win-amd64 wheels. The cygwin wheel can be removed from the next build, but now I'm not sure whether the other ones will be accepted.

mkbloke pushed a commit to mkbloke/streamlink that referenced this pull request Aug 18, 2020
@bastimeyer bastimeyer deleted the releases/1.1.0 branch January 19, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.1.0 release
3 participants