plugins.twitch: remove auth #2846
Conversation
|
PR is split into two commits, in case the private API endpoint stuff changes in the future, so we can simply revert the oauth token commit. |
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
+ Coverage 52.58% 52.66% +0.08%
==========================================
Files 249 249
Lines 15723 15674 -49
==========================================
- Hits 8268 8255 -13
+ Misses 7455 7419 -36 |
|
Changes look good, thanks @bastimeyer. |
|
There is something I don’t get: is it still possible to watch or download twitch streams with restricted access or not anymore? |
|
@milanserfaty It is not. |
|
Do you think this feature will be available again ? |
|
This has nothing to do with Streamlink, but with Twitch. If Twitch decides to make a public API endpoint available for retrieving the stream access tokens, then the Twitch auth feature could be added back to Streamlink. But since Twitch won't do this and has instead been actively blocking the access tokens for 3rd party API client IDs, this means that they'll probably never do this. There's no need to keep asking or begging. This is nothing which we have control over and the goal for us here is to make watching streams possible without going through loopholes like reading OAuth tokens from the web browser's dev tools. |
This removes or rather disables (non-breaking change) both authentication methods of the Twitch plugin:
--twitch-cookie)This has been deprecated and obsolete since many years and is non-functional anyway ever since they've upgraded their website. The API endpoint for aquiring a token with cookies does not exist anymore.
--twitch-oauth-token)This was already "disabled" by plugins.twitch: 410 Client Error (Gone for url) #2680/plugins.twitch: fix API issue - 410 gone error #2692 when we had to switch to Twitch's own API client-id for all private API calls. Since the streaming access token API endpoint is private and we can't use our own client-id here, all user's OAuth tokens can't be used as well, as they are tied to our client-id. When we added the changes, we kept the auth methods and the dummy login message, as we didn't want to delay the release any further (plugins.twitch: fix API issue - 410 gone error #2692 (comment)). This PR finally removes these remnants. The only effect is therefore the lack of the login log message if the parameter still gets used.
It also removes/disables the
--twitch-oauth-authenticateparameter, which is used for logging in and getting an OAuth token. The OAuth return page in the docs has also been removed, as it's not needed anymore.