Youtube Plugin Fix #2858
Merged
Youtube Plugin Fix #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the configuration schema because Youtube API changed.
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
==========================================
+ Coverage 52.67% 52.69% +0.02%
==========================================
Files 251 251
Lines 15753 15741 -12
==========================================
- Hits 8298 8295 -3
+ Misses 7455 7446 -9 |
|
Side-effect: resolves #1158 |
When youtube videos are protected, the ```url``` element is replaced by ```cipher```
|
@brouxco thanks for the contribution, code wise it looks good - I will test it out later. |
back-to
requested changes
Apr 3, 2020
There was a problem hiding this comment.
your current version will break other stuff
there is some more old code that can be removed
here is my unfinished solution, most of it should work
https://gist.github.com/back-to/2f0a8f296eb8b2ebdbf6b7da659f6dac
This was
linked to
issues
Apr 3, 2020
Sometimes (when the stream is live), we have ciphered urls but the HLS manifest is not.
back-to
requested changes
Apr 4, 2020
|
|
||
| if stream_info.get("stereo3d"): | ||
| name += "_3d" | ||
| name = stream_info["qualityLabel"] | ||
|
|
||
| streams[name] = stream |
There was a problem hiding this comment.
there are also duplicates HTTP streams
not directly related to your PR, just a small bug in Streamlink.
There was a problem hiding this comment.
I'm not really sure what you want me to do here.
Should I check if the HTTP stream is already in the streams?
|
|
|
I did it anyway. It looks like it's ok |
This comment has been minimized.
This comment has been minimized.
back-to
requested changes
Apr 4, 2020
and used {} instead of dict()
|
Do you want me to fix something else in my PR? |
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
May 14, 2020
Modified the configuration schema because Youtube API changed. Ciphered url does not necessarily means protected Sometimes (when the stream is live), we have ciphered urls but the HLS manifest is not. --- closes streamlink#1158 closes streamlink#2750 closes streamlink#2822
back-to
added a commit
to back-to/streamlink
that referenced
this pull request
Jun 14, 2020
Revert 'isLiveContent' from streamlink#2858 Added 'signatureCipher' for protected videos.
back-to
added a commit
that referenced
this pull request
Jun 21, 2020
back-to
added a commit
to back-to/streamlink
that referenced
this pull request
Jul 10, 2020
Revert 'isLiveContent' from streamlink#2858 Added 'signatureCipher' for protected videos. closes streamlink#3021
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
Modified the configuration schema because Youtube API changed. Ciphered url does not necessarily means protected Sometimes (when the stream is live), we have ciphered urls but the HLS manifest is not. --- closes streamlink#1158 closes streamlink#2750 closes streamlink#2822
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
Revert 'isLiveContent' from streamlink#2858 Added 'signatureCipher' for protected videos. closes streamlink#3021
resiproxy
pushed a commit
to resiproxy/streamlink
that referenced
this pull request
Nov 5, 2020
Modified the configuration schema because Youtube API changed. Ciphered url does not necessarily means protected Sometimes (when the stream is live), we have ciphered urls but the HLS manifest is not. --- closes streamlink#1158 closes streamlink#2750 closes streamlink#2822
resiproxy
pushed a commit
to resiproxy/streamlink
that referenced
this pull request
Nov 5, 2020
Revert 'isLiveContent' from streamlink#2858 Added 'signatureCipher' for protected videos. closes streamlink#3021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the configuration schema because Youtube API changed.
It works.
I kept a lot of the plugin code and got rid of the old useless code.
adp_audiomay not be accurate andadp_videois incomplete.I had a look at #2822. @fgietzen are you sure ffmpeg is installed on your system ?
I'm not sure who is in charge of this module. Maybe @beardypig ?