stream.hls: customizable playlist reload times #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
+ Coverage 52.59% 52.72% +0.12%
==========================================
Files 250 250
Lines 15715 15737 +22
==========================================
+ Hits 8266 8298 +32
+ Misses 7449 7439 -10 |
|
Do we care this doesn't work on 2.7? I'd rather just note that it doesn't. We already have PRs open to remove it. |
|
To be honest, I didn't properly check my changes regarding Python 2 (lack of experience) before submitting and also didn't run local tests on Python 2. I wasn't expecting this to be included in 1.4.0 anyway, but if somebody feels like it's important, then this can be fixed of course. Just wanted to get this out for review before I forget about it. |
via --hls-playlist-reload-time
bastimeyer
force-pushed
the
stream/hls/playlist-reload-time
branch
from
0e7c494 to
bc1544b
Compare
Merged
|
Now that we're past that pycountry hurdle I'm going to merge this since the next release will drop 2.7 support. Thanks @bastimeyer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for customizable HLS playlist reload times via
--hls-playlist-reload-time.Values can be
"segment"- sets refresh time to the duration of the last segment"live-edge"- sets refresh time to the sum of durations of thelive-edge - 1last segmentsFor all other values, falls back to the playlist's
target_durationif it is set, otherwise does the same aslive-edge(this logic got changed, wassegmentbefore), and if no target duration and no segments are present, then the default value of 15 is used.Also renames
HLSStreamWorker._set_playlist_reload_timetoHLSStreamWorker._playlist_reload_timeand sets the reload time from its return value instead.The changes are rather trivial, but I'd like to improve the integration tests a bit. It currently only tests one playlist refresh. Ideally, multiple playlists should be tested, but I couldn't set up a simple method spy with unittest.mock. Help and feedback is appreciated.