plugins.yupptv: fix/minor rewrite #3116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3116 +/- ##
==========================================
- Coverage 52.81% 52.62% -0.20%
==========================================
Files 244 243 -1
Lines 15559 15610 +51
==========================================
- Hits 8218 8214 -4
- Misses 7341 7396 +55 |
|
A few notes: I have now tested this as best I can under both Py2 and Py3. I have an account, but I do not have any package subscription, so cannot test fully, but the code that was already in the plugin which deals with that still seems to be valid. I've added very little original code to this plugin, almost all additions are ripped from the pixiv plugin. I suggest giving the code a once-over/sanity check, testing against the freely available streams which appear not to be geo-IP restricted and then merge, given that full testing is otherwise impossible without a subscription and therefore, it will be necessary to rely on user reports (or lack of). Cheers. |
- Remove site login code and device logout code - Add credentials caching/purging code and command line options - Fix class name in plugin test, update tests to loop over list - Minor update to negative test function name
mkbloke
force-pushed
the
yupptv-site-change-2020-08-1
branch
from
fd207f6 to
1b7d898
Compare
|
Let's merge this, as discussed in the release PR. If there are any further issues, they can be fixed later. Thanks for the rewrite! |
- Remove site login code and device logout code - Add credentials caching/purging code and command line options - Fix class name in plugin test, update tests to loop over list - Minor update to negative test function name
Fix for #3094. Verified as working by one user: #3094 (comment)
closes #3094