support python -m invocation style
#3174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that `python -mstreamlink` raises an error, at least on Windows: No module named streamlink.__main__; 'streamlink' is a package and cannot be directly execute This can be fixed by adding the __main__.py files to both `streamlink_cli` and `streamlink`.
PleasantMachine9
force-pushed
the
master
branch
from
6fc3ca9 to
4d9eb66
Compare
Codecov Report
@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
- Coverage 52.67% 52.66% -0.01%
==========================================
Files 244 244
Lines 15636 15636
==========================================
- Hits 8236 8235 -1
- Misses 7400 7401 +1 |
|
@gravyboat is there someone I message for review? The contributing document is not really clear about what to do with a submitted pull request to get a review. |
|
@PleasantMachine9 No you don't need to do anything. When someone has time they'll review it. Looks good to me but I'm not willing to merge without one of the other maintainers weighing in. |
|
No one else has weighed in and this looks good to me so I'm merging it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
python -m streamlink -hraises an error, at least on Windows:This can be fixed by adding the
__main__.pyfiles to bothstreamlink_cliandstreamlinkpackages with the appropriate content.