stream.hls_filtered: fix tests #3194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor test setup and properly tear down threads - Re-order tests - Change mocked request URLs to temporarily work around bleeding threads from previously run HLSStream tests which are sometimes still making requests on the same URLs and causing the mocked playlist URL to incorrectly advance one call and breaking the current stream worker
Merged
Codecov Report
@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
+ Coverage 52.65% 52.67% +0.01%
==========================================
Files 244 244
Lines 15687 15687
==========================================
+ Hits 8260 8263 +3
+ Misses 7427 7424 -3 |
|
Btw, I believe the slightly incorrect coverage results in some PRs are a result of the other HLSStream related tests not tearing down properly. The code lines which are run sometimes and sometimes not are these:
|
|
Nice this looks good, thanks @bastimeyer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from previously run HLSStream tests which are sometimes still making
requests on the same URLs and causing the mocked playlist URL to
incorrectly advance one call and breaking the current stream worker
Resolves #3187
See #3187 (comment)
As mentioned in the linked comment, test_hls.py and test_twitch.py need to be fixed at some point, so that they gracefully tear down their spawned HLSStream threads, so that the same mocked request URLs don't get queried in tests which are run (directly) afterwards. Using unique mocked request URLs in each test would make this extra safe.
All tests successfully ran 50 times in a row on all CI runners on my test-account's fork:
https://github.com/bastimeyer-test/streamlink-test/actions/runs/266975807