docs: update plugin guidelines #3244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravyboat
requested changes
Oct 11, 2020
| 8. Sites which are unmaintained | ||
|
|
||
| 9. Sites which don't provide any video streaming content, eg. radio stations | ||
|
|
There was a problem hiding this comment.
I think it's worth adding a few additional lines such as:
10. Sites which create a live stream of previously recorded content, such as TV shows, movies, news broadcasts, etc.
11. Sites which have no way to determine viewership numbers
12. Sites which are static cameras of a physical location
13. Sites which are in beta or undergoing heavy amounts of development and may change rapidly
This should cover us for more plugins and keep people from wasting their time and ours.
There was a problem hiding this comment.
I agree with all of those, but I feel like a list of 13 points makes it a bit too much IMO.
There was a problem hiding this comment.
Agreed, your changes are good.
bastimeyer
force-pushed
the
docs/update-plugin-guidelines
branch
from
da679d2 to
35739cf
Compare
bastimeyer
changed the title
Is that okay? |
|
Yep! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last revision of the plugin request/submission guidelines was made two years ago in #1838.
Lately we've seen a few requests and PRs for radio stations, which we don't want to merge. This should be included in the list of plugin restrictions.
I've also added a generic pull request template, since we don't have one. Nothing big, just a small reminder to read the guidelines, add a comment and run local checks if possible.