plugins.pluto: new plugin for https://pluto.tv/ #3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://pluto.tv/live-tv/ - Livestreams will break during commercials, without the `self.session.set_option('ffmpeg-fout', 'mpegts')` option enabled. - VODs might work without it, but I did not test it. closes streamlink#854 closes streamlink#2747 closes streamlink#3156 Co-authored-by: calculon-jr <54852718+calculon-jr@users.noreply.github.com>
bastimeyer
reviewed
Nov 25, 2020
src/streamlink/plugins/pluto.py
Outdated
| return self.title | ||
|
|
||
| def _schema_media(self, slug): | ||
| return validate.Schema(validate.all( |
There was a problem hiding this comment.
validate.Schema is already a wrapper for validate.all.
src/streamlink/plugins/pluto.py
Outdated
Comment on lines
35
to
36
| 'name': validate.text, | ||
| 'slug': validate.text, |
There was a problem hiding this comment.
Just use str instead of validate.text
src/streamlink/plugins/pluto.py
Outdated
|
|
||
|
|
||
| class Pluto(Plugin): | ||
| _re_url = re.compile(r'''(?x)^https?://(?:www\.)?pluto\.tv/(?: |
There was a problem hiding this comment.
For readability reasons, it's better to set the re.VERBOSE option in the re.compile call itself instead of the regex string.
src/streamlink/plugins/pluto.py
Outdated
| return | ||
|
|
||
| self.title = data.get('name') | ||
| stream_link_no_sid = data['stitched']['urls'][0]['url'] |
There was a problem hiding this comment.
The stitched attribute gets validated as optional in the schema above. If it's missing in the response, this statement will raise a KeyError.
back-to
added
the
PR: squash commits
|
When trying to run streamlink with a live-tv link, regardless of the channel (slug_live) given it defaults to newsy (this incidentally has no stitched and fails, but regardless the main issue is it seems the given slug is not being processed properly somewhere). |
|
@WayoshiM run with |
|
@gravyboat I installed with pip with the latest .git version. I think the issue might be that |
|
Correct newsy doesn't have stitched. so isStitched is false |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 15, 2020
https://pluto.tv/live-tv/ - Livestreams will break during commercials, without the `self.session.set_option('ffmpeg-fout', 'mpegts')` option enabled. - VODs might work without it, but I did not test it. closes streamlink#854 closes streamlink#2747 closes streamlink#3156 Co-authored-by: calculon-jr <54852718+calculon-jr@users.noreply.github.com> streamlink#3363 added to plugin matrix added test
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 15, 2020
https://pluto.tv/live-tv/ - Livestreams will break during commercials, without the `self.session.set_option('ffmpeg-fout', 'mpegts')` option enabled. - VODs might work without it, but I did not test it. closes streamlink#854 closes streamlink#2747 closes streamlink#3156 Co-authored-by: calculon-jr <54852718+calculon-jr@users.noreply.github.com> streamlink#3363 added to plugin matrix added test
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 17, 2020
https://pluto.tv/live-tv/ - Livestreams will break during commercials, without the `self.session.set_option('ffmpeg-fout', 'mpegts')` option enabled. - VODs might work without it, but I did not test it. closes streamlink#854 closes streamlink#2747 closes streamlink#3156 Co-authored-by: calculon-jr <54852718+calculon-jr@users.noreply.github.com> streamlink#3363 added to plugin matrix added test
|
Would be nice with support for closed captions/subtitles in this plugin. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pluto.tv/live-tv/
self.session.set_option('ffmpeg-fout', 'mpegts')option enabled.closes #854
closes #2747
closes #3156
Co-authored-by: calculon-jr 54852718+calculon-jr@users.noreply.github.com